migration/07 umbrella chart - #9
Open
CptSchnitz wants to merge 2 commits into
Open
Conversation
Chart.lock pinned mclabels at 1.0.1 while Chart.yaml already declared 1.1.0, present since the workspace-move commit and unrelated to this change. helm dependency build refuses to run at all while the two disagree, which blocks rendering anything from this chart. Chart.yaml is untouched; this only brings the lock back in sync with what it already declared. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Add charts/jobnik as an umbrella chart named for the product, with the manager chart pulled in as a conditioned dependency via a file:// reference rather than being physically moved. The subchart's directory, name and contents are untouched, so the manager's deployment selector and every object name stay exactly as they are. Verified by rendering both charts with the same release name: the umbrella render is byte-identical to the standalone manager render once the harmless `# Source:` comment path is normalized, and both charts lint clean. The comparison is recorded in the ticket. Also: - extends the pull-request helm-lint job to cover the new umbrella chart - prepares (but cannot push, since it lives in another repository) the matching deployment-configuration change, referenced from the ticket Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Coverage Report for apps/jobnik-manager
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬