Skip to content

feat: upgrade to the new ts-server-boilerplate(MAPCO-10112)#45

Merged
almog8k merged 14 commits into
masterfrom
feat/boilerplat-maintenance
Jun 10, 2026
Merged

feat: upgrade to the new ts-server-boilerplate(MAPCO-10112)#45
almog8k merged 14 commits into
masterfrom
feat/boilerplat-maintenance

Conversation

@almog8k

@almog8k almog8k commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Context

Upgrades cache-seeder from the old MapColonies boilerplate to the new ts-server-boilerplate generation, using the already-migrated job-tracker as the reference. Preserves the two service-specific traits the boilerplate doesn't have: the worker polling mainLoop and the MapProxy Python integration (Docker venv + cmd.ts). The service stays on Jest and intentionally skips OpenAPI (it's a routeless worker).

What changed

  • Config: @map-colonies/config + commonBoilerplateV3 schema (src/common/config.ts); restructured config/*.json (telemetry reshaped, httpRetry moved top-level due to schema unevaluatedProperties, openapiConfig added).
  • Bootstrap: async getApp/registerExternalValues, ESM instrumentation.mts, js-logger v5, prom-client metrics (replaces OTel meter), @map-colonies/tracing. Fixed a latent terminus onSignal misplacement.
  • Tooling: @map-colonies/tsconfig + path aliases, ESLint 9 flat config, prettier 3, tsc-alias build, husky v9, Node-24 Dockerfile with --import instrumentation.mjs + offline config.
  • Deps: migrated + version-bumped to match the boilerplate; removed unused packages (http-status-codes, supertest, @types/supertest, @types/multer, jest-create-mock-instance, standalone commitlint); moved @faker-js/faker to devDependencies.
  • Helm: added configManagement (CONFIG_*) env for the new config library (offline mode); removed dead OTel-push metrics env.
  • Tests: ts-jest with path-alias mapper, sync logger mock, direct registerDependencies setup.

@almog8k almog8k force-pushed the feat/boilerplat-maintenance branch from 4262005 to df75932 Compare June 4, 2026 15:45
@almog8k almog8k changed the title feat: upgrade to the new ts-server-boilerplate feat: upgrade to the new ts-server-boilerplate(MAPCO-10112) Jun 8, 2026

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
few comment
and we should talk about the IConfig uses, in general we should remove it and use the ConfigType as type

Comment thread config/custom-environment-variables.json Outdated
Comment thread helm/templates/configmap.yaml Outdated
Comment thread helm/Chart.lock Outdated
Comment thread helm/values.yaml Outdated
Comment thread src/cacheSeed/cacheSeedManager.ts Outdated
Comment thread src/mapproxyUtils/mapproxySeed.ts Outdated
Comment thread src/app.ts Outdated
Comment thread tests/unit/cacheSeed/cacheSeedManager.spec.ts
Comment thread tests/unit/serviceClients/jobTrackerClient.spec.ts
Comment thread tests/unit/serviceClients/mapproxyConfig.spec.ts
@almog8k almog8k merged commit 4b120d7 into master Jun 10, 2026
4 checks passed
@almog8k almog8k deleted the feat/boilerplat-maintenance branch June 10, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants