fix: resolve potential bugs - RETURN in loop, overly broad CATCH#42
Merged
Conversation
- precheck_update: RETURN exited entire method after first failing entity, preventing validation of subsequent entities. Changed to CONTINUE. - ev_producer_resolver: CATCH cx_root swallowed all exceptions including system errors. Narrowed to zasis_cx_exc and cx_sy_create_object_error. Fixes #26
… values query Replace overly broad CATCH cx_root (which swallowed all exceptions and stored results in dead variables) with specific catches: - cx_rap_query_filter_no_range: filter cannot be converted to ranges - cx_sy_move_cast_error: domain is not an elementary type Both return empty result. Unexpected exceptions now propagate to the RAP framework for proper error surfacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Changes
RETURN → CONTINUE in
precheck_updateLOOP (zbp_asis_i_ruleset.clas.locals_imp.abap)CATCH cx_root → specific exceptions in
zasis_cl_ev_producer_resolver.clas.abapzasis_cx_excandcx_sy_create_object_errorinstead of swallowing all exceptions.