refactor: fix redundant ops and wasteful patterns (issue #28)#41
Merged
Conversation
- Remove redundant to_upper() calls from resolver callers; check_implements owns normalization internally via CONV string() - Guard JSON deserialization behind POST check; GET requests have no body - Replace verbose IF/ELSE DI blocks with COND #() in interpreter constructor Closes #28
- Version bump 0.2.1 -> 0.2.2 (patch: refactors + style fixes) - AGENTS.md: grill-me now invoked before branch creation on intent signal - AGENTS.md: version bump step added before session summary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Changes
1. Remove redundant
to_upperfrom resolver callerscheck_implementsinternally normalizes — callers in resolver classes no longer need to duplicate this.2. Guard JSON deserialization for POST only
GET requests have no body; deserialization now only runs when method is POST.
3. Replace IF/ELSE DI pattern with
COND #()in interpreter constructorThree repetitive IF/ELSE blocks replaced with inline COND expressions, consistent with factory class style.