fix: technical debt - typos, dead code, inconsistent casing (#31)#40
Merged
Conversation
- Fix typo: Authorizaton -> Authorization in zasis_cl_http_handler - Fix typo: unkown -> unknown in zasis_msgs msg 007 - Fix casing: duplicate_ruleSetId -> duplicate_rulesetid in zasis_cx_ruleset_ui - Fix casing: no_AUTH -> no_auth in zasis_cx_ruleset_ui - Remove dead sy-subrc check after SELECT INTO TABLE in zasis_cl_get_domain_fix_values; add ##SUBRC_OK pragma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Changes
Authorizaton→Authorizationinzasis_cl_http_handlerunkown→unknowninzasis_msgs(msg 007)duplicate_ruleSetId→duplicate_rulesetidinzasis_cx_ruleset_uino_AUTH→no_authinzasis_cx_ruleset_uisy-subrccheck after SELECT INTO TABLE inzasis_cl_get_domain_fix_values; add#EC CI_SUBRCpseudo comment