Bump to MadNLP 0.10, ExaModels 0.11 #45
Open
michel2323 wants to merge 3 commits into
Open
Conversation
michel2323
force-pushed
the
ms/version_bump
branch
from
98b5a6d to
7872b10
Compare
michel2323
force-pushed
the
ms/version_bump
branch
from
7872b10 to
0b7ac38
Compare
The model is built at element type T but parse_ac_power_data always parsed the matpower file as Float64, so a T=Float32 model carried Float64 GenData/BusData/BranchData and its objective evaluated to Float64. MadNLP <=0.8 hid this by storing the objective via setproperty! (which converts); MadNLP 0.10 stores it via set_obj_val! -> setfield! (no convert), raising "TypeError: in setfield!, expected Float32, got a value of type Float64".
Build every ExaModel with prod = true so the KernelAbstractions jtprod! kernels MadNLP 0.10 uses for multiplier recovery are generated for the CPU()/CUDABackend() configs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 89.11% 88.86% -0.25%
==========================================
Files 9 9
Lines 1304 1275 -29
==========================================
- Hits 1162 1133 -29
Misses 142 142 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.