Skip to content

fix(#274): make full 44pt toolbar button circle tappable #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cassio-rossi merged 1 commit into from
Jul 23, 2026
Merged

fix(#274): make full 44pt toolbar button circle tappable #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...cMagazineUILibrary/Sources/MacMagazineUILibrary/Cards/Extensions/MinimumTouchTarget.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,19 @@ private struct MinimumTouchTarget: ViewModifier {

func body(content: Content) -> some View {
content
.buttonStyle(.plain)
.buttonStyle(MinimumTouchTargetButtonStyle())
.glassEffect(.regular.tint(selected ? selectedColor.opacity(0.3) : .clear).interactive(), in: .circle)
}
}

/// Expands the tappable area from inside the button so the full 44pt circle
/// receives taps — a `frame`/`contentShape` applied outside a `Button` only
/// resizes the visual glass, not the button's hit-test region (FB22155477).
private struct MinimumTouchTargetButtonStyle: ButtonStyle {
func makeBody(configuration: Configuration) -> some View {
configuration.label
.frame(width: 44, height: 44)
.contentShape(Circle())
.glassEffect(.regular.tint(selected ? selectedColor.opacity(0.3) : .clear).interactive(), in: .circle)
.opacity(configuration.isPressed ? 0.4 : 1)
}
}
Loading