feature: map editor (part 2)#811
Conversation
…erSpawnArea under IMapArea interface
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the second phase of the Map Editor feature, focusing on enhancing user interaction and visual feedback. By implementing multi-selection filters, player tracking, and intuitive keyboard shortcuts, the update significantly improves the efficiency and usability of map management tasks. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a 'Follow Player' feature to the live map, refactors the map editor to use a unified IMapArea interface for gates and spawn areas, and refines map styling. The review feedback identifies several critical issues: a potential application crash caused by async void background timer callbacks in MapPage.razor, a memory leak in map-launcher.js where disposed maps are not cleaned up from the global registry, a logic bug in MapPlayerList.razor when no player is followed, and a missing validation check in MapEditor.razor.cs that could corrupt the undo history.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Features
Screencast_20260628_002737.webm-10mb.mp4