Skip to content

feature: map editor (part 2)#811

Open
eduardosmaniotto wants to merge 13 commits into
MUnique:masterfrom
eduardosmaniotto:feature/map-editor2
Open

feature: map editor (part 2)#811
eduardosmaniotto wants to merge 13 commits into
MUnique:masterfrom
eduardosmaniotto:feature/map-editor2

Conversation

@eduardosmaniotto

@eduardosmaniotto eduardosmaniotto commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Features

  • Update Map Editor colors, making objects more distinguishable.
  • Implement map filter multi-selection.
  • Implement Live Map player follow.
  • Include the SHIFT shortcut to cycle overlapping objects.
  • Include the CTRL shortcut to move objects to avoid unintentional object movement.
Screencast_20260628_002737.webm-10mb.mp4

@eduardosmaniotto eduardosmaniotto marked this pull request as ready for review July 5, 2026 18:51
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the second phase of the Map Editor feature, focusing on enhancing user interaction and visual feedback. By implementing multi-selection filters, player tracking, and intuitive keyboard shortcuts, the update significantly improves the efficiency and usability of map management tasks.

Highlights

  • Map Editor Visuals: Updated object colors and styles to improve distinguishability and visual clarity.
  • Map Filter Multi-selection: Implemented multi-selection support for map filters, allowing users to view multiple object types simultaneously.
  • Live Map Player Tracking: Added functionality to track and follow players in real-time on the live map.
  • Keyboard Shortcuts: Introduced SHIFT for cycling through overlapping objects and CTRL to prevent unintentional object movement.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'Follow Player' feature to the live map, refactors the map editor to use a unified IMapArea interface for gates and spawn areas, and refines map styling. The review feedback identifies several critical issues: a potential application crash caused by async void background timer callbacks in MapPage.razor, a memory leak in map-launcher.js where disposed maps are not cleaned up from the global registry, a logic bug in MapPlayerList.razor when no player is followed, and a missing validation check in MapEditor.razor.cs that could corrupt the undo history.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/Web/Map/Components/MapPlayerList.razor Outdated
Comment thread src/Web/Map/wwwroot/js/map-launcher.js
Comment thread src/Web/AdminPanel/Pages/MapPage.razor Outdated
Comment thread src/Web/Shared/Components/MapEditor/MapEditor.razor.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant