Replaced linear system matrix operation functions with modified LAPACK implementations.#1487
Open
robertmullis wants to merge 2 commits into
Open
Replaced linear system matrix operation functions with modified LAPACK implementations.#1487robertmullis wants to merge 2 commits into
robertmullis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to replace the current implementation of the functions for solving a linear system by LU factorization with LAPACK versions with BSD3 licensing: https://github.com/Reference-LAPACK/lapack/tree/master. The two functions being added are mpas_getrf and mpas_getrs, which are modified versions of LAPACK's DGETF2 and DGETRS. mpas_migs and mpas_legs were also updated to act as a wrapper for these functions, and they are called through the src files.
Unit testing was performed by using a test set of values and comparing the LAPACK implementations with the legacy versions and Wolfram Alpha. The tests resulted in outputs with a difference within ~1.0e-15 of the original implementation and ~4.0e-14 of Wolfram Alpha.
Linking the LAPACK library for performance was considered, but adding timers to the mpas_migs and mpas_legs functions revealed that they add a negligible amount of time. On a 1-degree test case that lasted 150.58s, the updated functions contributed only 0.009s.