feat: add 5 China authoritative sources (AM batch 2026-04-25)#177
Open
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Open
feat: add 5 China authoritative sources (AM batch 2026-04-25)#177firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Conversation
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
明察 QA Review — PR #177
✅ 通过项
- 保密检查 ✅(无 Langfuse/GitLab)
- ID 去重 5/5 ✅(nmc/crsri/caep/cima/giec 均无重复)
- 域名去重 5/5 ✅
- URL 可达 4/5 ✅:nmc 200, crsri 200, caep 200, cima 200
- Domain 格式 ✅
- Schema 必填字段齐全 ✅
⚠️ 需修改
-
tags 问题(同 #174/#176) — 5 个源全部含中文 tags + 空格 tags。三个 PR 一起改:
- 移除所有中文 tags
- 空格改连字符(如
weather forecast→weather-forecast)
-
china-giec HTTPS 不通 —
https://www.giec.ac.cn返回 000,http://www.giec.ac.cn返回 200。PR 中已用 http,没问题
7 tasks
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
QA Review — PR #177 (5 China sources AM batch)
✅ Passed
- ID uniqueness: 5/5 unique, no conflicts with existing sources
- Domain/website dedup: no existing sources with same domains
- Domains format: all kebab-case ✅
- Schema structure: valid
⚠️ Issues Found
1. HTTP → HTTPS upgrade needed (3 URLs)
china-nmc:http://www.nmc.cn→ supports HTTPS (verified 200), should usehttps://china-nmc:data_urlalso HTTPchina-cnfa(if included): redirects to HTTPSchina-chts(if included): redirects to HTTPS
Actually checking the 5 sources:
nmc.cn→ HTTPS returns 200 ✅ → upgrade to httpsgiec.ac.cn→ HTTPS connection fails, HTTP 200 → keep http⚠️ caep.org.cn→ HTTPS connection fails, HTTP 200 → keep http⚠️ crsri.cn→ HTTPS connection fails, HTTP 200 → keep http⚠️ cima.org.cn→ HTTPS connection fails, HTTP 200 → keep http⚠️
Action: Please upgrade china-nmc website and data_url to https://
📊 URL Reachability
All 5 websites return HTTP 200 ✅
- china-nmc: 中央气象台 (National Meteorological Centre) - real-time weather - china-crsri: 长江科学院 (Changjiang River Scientific Research Institute) - water resources - china-caep: 生态环境部环境规划院 (Chinese Academy of Environmental Planning) - china-cima: 中国仪器仪表行业协会 (China Instrumentation Industry Association) - china-giec: 中科院广州能源研究所 (Guangzhou Institute of Energy Conversion, CAS)
f38a2f0 to
b3432ea
Compare
mingcha-dev
approved these changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 Re-review — PR #177 APPROVED ✅
china-nmc 已升级 HTTPS ✅ 其余 4 源 HTTP-only 确认无 HTTPS。全部检查通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增中国权威数据源(上午批次 2026-04-25)
本 PR 新增 5 个中国权威数据源,覆盖气象、水资源、生态环境、仪器仪表和能源研究领域。
新增数据源
检查清单
make check通过(545 个 ID 唯一,schema 有效)git add新增 JSON 文件