Skip to content

1687 fix: Make OpenMP no_create a documented no-op instead of aborting fypp. #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
engineer-scientist wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −6
Open

1687 fix: Make OpenMP no_create a documented no-op instead of aborting fypp. #1724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98b98cc
Make OpenMP no_create a documented no-op instead of aborting fypp
claude Aug 12, 2026
d7736ff
Merge branch 'master' into claude/mflowcode-issue-1687-yic86y
engineer-scientist Aug 12, 2026
3a8410b
Merge branch 'master' into claude/mflowcode-issue-1687-yic86y
engineer-scientist Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/documentation/gpuParallelization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ This wraps the lines in `code` with parallelization calls to openACC or openMP,
| `copyinReadOnly` | string list | None | Allocates and copies readonly data to GPU and then deallocated on exit |
| `copyout` | string list | None | Allocates data on GPU on entrance and then deallocates and copies to CPU on exit |
| `create` | string list | None | Allocates data on GPU on entrance and then deallocates on exit |
| `no_create` | string list | None | Use data in CPU memory unless data is already in GPU memory |
| `no_create` | string list | None | Use data in CPU memory unless data is already in GPU memory (OpenACC only) |
| `present` | string list | None | Data that must be present in GPU memory. Increment counter on entrance, decrement on exit |
| `deviceptr` | string list | None | Pointer variables that are already allocated on GPU memory |
| `attach` | string list | None | Attaches device pointer to device targets on entrance, then detach on exit |
Expand Down Expand Up @@ -184,7 +184,7 @@ Uses FYPP call directive using `#:call`
| `copyinReadOnly` | string list | None | Allocates and copies readonly data to GPU and then deallocated on exit |
| `copyout` | string list | None | Allocates data on GPU on entrance and then deallocates and copies to CPU on exit |
| `create` | string list | None | Allocates data on GPU on entrance and then deallocates on exit |
| `no_create` | string list | None | Use data in CPU memory unless data is already in GPU memory |
| `no_create` | string list | None | Use data in CPU memory unless data is already in GPU memory (OpenACC only) |
| `present` | string list | None | Data that must be present in GPU memory. Increment counter on entrance, decrement on exit |
| `deviceptr` | string list | None | Pointer variables that are already allocated on GPU memory |
| `attach` | string list | None | Attaches device pointer to device targets on entrance, then detach on exit |
Expand Down Expand Up @@ -247,7 +247,7 @@ Uses FYPP call directive using `#:call`
| `copyinReadOnly` | string list | None | Allocates and copies a readonly variable to GPU and then deallocated on exit |
| `copyout` | string list | None | Allocates data on GPU on entrance and then deallocates and copies to CPU on exit |
| `create` | string list | None | Allocates data on GPU on entrance and then deallocates on exit |
| `no_create` | string list | None | Use data in CPU memory unless data is already in GPU memory |
| `no_create` | string list | None | Use data in CPU memory unless data is already in GPU memory (OpenACC only) |
| `present` | string list | None | Data that must be present in GPU memory. Increment counter on entrance, decrement on exit |
| `deviceptr` | string list | None | Pointer variables that are already allocated on GPU memory |
| `attach` | string list | None | Attaches device pointer to device targets on entrance, then detach on exit |
Expand Down
6 changes: 3 additions & 3 deletions src/common/include/omp_macros.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@
#:enddef

#:def OMP_NOCREATE_STR(no_create)
#:if no_create is not None
#:stop 'no_create is not supported yet'
#:endif
#! OpenMP has no no_create equivalent; OMP_DEFAULT_STR already maps
#! present-by-default, so emit nothing. Aborting here would also break
#! OpenACC builds, which expand both backends before #if selects one.
#:set no_create_val = ''
$:no_create_val
#:enddef
Expand Down
Loading