main

[mansibrahman03]

What does this PR do?

I added a flag() method in toolchain/mfc/case_validator.py that functions to replace the verbose idiom "self.get(x,F)==T" repeated in 134 places across the file. I also updated ast_analyzer.py to recognize calls made to flag().

Why was this PR needed?

The repetition of the verbose idiom in case_validator.py made the code hard to read and more prone to error. The flag() helper centralizes the logical convention in one place. The change to ast_analyzer.py was needed to ensure this new helper method is recognized.

What are the relevant issue numbers?

Closes #1508

Testing

All tests on flag() helper and coupling passing in toolchain/mfc/params_tests/test_flag_helper.py.

Does this PR meet the acceptance criteria?

• Tests added for new/changed behavior
• All tests passing
• Follows project style guide
• No breaking changes introduced
• Documentation updated

[mansibrahman03]

Hi @sbryngelson — this is my first contribution to this project. I've fixed issue #1508 by adding the flag() helper method in case_validator.py and updating ast_analyzer.py to recognize calls to flag(). Would appreciate a review when you have time!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.39%. Comparing base (ac5774e) to head (c188d37).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   60.94%   60.39%   -0.56%     
==========================================
  Files          82       83       +1     
  Lines       19922    19854      -68     
  Branches     2924     2955      +31     
==========================================
- Hits        12141    11990     -151     
- Misses       5805     5863      +58     
- Partials     1976     2001      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.