feat(validate): add --all flag to validate all example case files#1620
Open
adityaraut09 wants to merge 1 commit into
Open
feat(validate): add --all flag to validate all example case files#1620adityaraut09 wants to merge 1 commit into
adityaraut09 wants to merge 1 commit into
Conversation
adityaraut09
force-pushed
the
feat/validate-all-flag
branch
from
1bc1aaf to
88d7a31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1529
Adds an
--allflag to./mfc.sh validatethat loops through all example case files and reports which ones pass or fail, rather than requiring the user to check them one at a time manually.Type of change
Changes
toolchain/mfc/cli/commands.py: madeinputpositional optional (nargs="?"), added--all/-aflag toVALIDATE_COMMANDtoolchain/mfc/validate.py: added_validate_one()helper and--allbranch that globsexamples/**/case.py, validates each, and prints a pass/fail summaryTesting
Verified syntax with
python3 -c "import ast; ast.parse(...)". Full integration test requires the MFC build environment.