revert: remove --prebuilt-prefix (spack-only feature)#1448
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
sbryngelson
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
=======================================
Coverage 61.31% 61.31%
=======================================
Files 72 72
Lines 19771 19771
Branches 2852 2852
=======================================
Hits 12123 12123
Misses 5699 5699
Partials 1949 1949 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the spack-specific additions from #1444, keeping only the defensive
deactivateguard inmfc.shwhich is useful regardless.What's removed
--prebuilt-prefixCLI flag frommfc.sh runandmfc.sh testMFC_PREBUILT_PREFIXenvironment variable supportget_prebuilt_prefix()intoolchain/mfc/common.pytoolchain/mfc/build.pytoolchain/bootstrap/python.shWhy
The spack package for MFC is being parked — the upstream
spack/spack-packagesPR has unclear ROI given MFC already hasinstall.shand full CI on Frontier and Phoenix. These toolchain changes only exist to support that spack workflow.What's kept
The
if type deactivateguard inmfc.sh— defensive and independently useful.