Remove Non-parameter workaround for Chemistry cases with AMD

[anandrdbz]

Description

Removes the non-parameter workaround for chemistry with AMD compilers, allowing to run chemistry cases with variable num_species. No fixes are needed on Pyrometheus. @DimAdam-01 @sbryngelson

In addition, the PR removes run_time_info from the igr benchmark case as this should've never been set to true

Verified all chemistry test cases pass on frontier with AMD compilers

Fixes #(issue)

Type of change

• Bug fix
• New feature
• Refactor
• Documentation
• Other: describe

Testing

How did you test your changes?

Checklist

• I added or updated tests for new behavior
• I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)

• GPU results match CPU results
• Tested on NVIDIA GPU or AMD GPU

AI code reviews

Reviews are not triggered automatically. To request a review, comment on the PR:

• @coderabbitai review — incremental review (new changes only)
• @coderabbitai full review — full review from scratch
• /review — Qodo review
• /improve — Qodo code suggestions
• @claude full review — Claude full review (also triggers on PR open/reopen/ready)
• Add label claude-full-review — Claude full review via label

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[github-actions]

Claude Code Review

Head SHA: 904b5a7

Files changed:

• 7
• benchmarks/igr/case.py
• src/common/m_checker_common.fpp
• src/common/m_chemistry.fpp
• src/simulation/include/inline_riemann.fpp
• src/simulation/m_cbc.fpp
• src/simulation/m_riemann_solvers.fpp
• src/simulation/m_start_up.fpp

Findings:

[GPU Correctness – AMD] molecular_weights device initialization no longer guaranteed after removing the AMD initialization block

src/simulation/m_start_up.fpp removes the block that was the sole mechanism transferring molecular_weights data to the AMD GPU device:

! Removed:
#:if USING_AMD
    block
        use m_thermochem, only: molecular_weights
        use m_chemistry, only: molecular_weights_nonparameter
        molecular_weights_nonparameter(:) = molecular_weights(:)
        $:GPU_UPDATE(device='[molecular_weights_nonparameter]')
    end block
#:endif

And src/common/m_chemistry.fpp removes the module-level GPU_DECLARE that backed it:

! Removed:
#:if USING_AMD
    real(wp) :: molecular_weights_nonparameter(10) = ...
    $:GPU_DECLARE(create='[molecular_weights_nonparameter]')
#:endif

After this PR, every AMD GPU kernel in m_chemistry.fpp, m_cbc.fpp, m_riemann_solvers.fpp, and inline_riemann.fpp uses molecular_weights from m_thermochem directly inside GPU_PARALLEL_LOOP blocks. This is only correct if m_thermochem has its own GPU_DECLARE for molecular_weights and a corresponding GPU_UPDATE(device=...) to populate it before the first kernel launch. Neither is visible in the changed files. If molecular_weights is not device-resident on AMD, the GPU kernels will silently read uninitialised or stale device memory, producing wrong species reaction rates, enthalpies, and mole fractions without any runtime error.

Please confirm that m_thermochem (not changed in this PR) has $:GPU_DECLARE(create='[molecular_weights]') and a matching $:GPU_UPDATE(device='[molecular_weights]') call that executes before s_initialize_gpu_vars returns.

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.31%. Comparing base (dd231ae) to head (904b5a7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/simulation/m_cbc.fpp	0.00%	2 Missing ⚠️
src/simulation/m_riemann_solvers.fpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1446   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files          72       72           
  Lines       19771    19771           
  Branches     2852     2852           
=======================================
  Hits        12123    12123           
  Misses       5699     5699           
  Partials     1949     1949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.