Skip to content

fix: correct single-precision CI testing#1400

Open
sbryngelson wants to merge 2 commits intoMFlowCode:masterfrom
sbryngelson:fix/single-precision-testing
Open

fix: correct single-precision CI testing#1400
sbryngelson wants to merge 2 commits intoMFlowCode:masterfrom
sbryngelson:fix/single-precision-testing

Conversation

@sbryngelson
Copy link
Copy Markdown
Member

@sbryngelson sbryngelson commented May 5, 2026

Closes #759

Summary

  • Add \$PRECISION to the Test step in `.github/workflows/test.yml` so single-precision binaries are actually tested with `--single` tolerances (root bug: `$PRECISION` was only in the Build step env, so the Test step ran double-precision test selection/tolerance against single-precision output)
  • Change single-precision CI job from `mpi: no-mpi` to `mpi: mpi` so `--test-all` is passed and a broader test set is exercised

Test plan

  • CI single-precision job builds with `--mpi --single`
  • CI single-precision job runs tests with `--single` flag (1e-1 tolerances)
  • No regressions in regular (double-precision) CI jobs

@sbryngelson sbryngelson marked this pull request as ready for review May 6, 2026 14:06
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 41 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e64f732f-bbe4-4b10-b997-1d0a7528f27a

📥 Commits

Reviewing files that changed from the base of the PR and between d513442 and 84ffb7a.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown
Contributor

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Claude Code Review

Head SHA: 84ffb7a

Files changed:

  • 1
  • .github/workflows/test.yml

Findings

Implicit --test-all side effect from mpi: no-mpimpi: mpi

The matrix entry changed at line 175 (mpi: no-mpimpi: mpi) silently activates --test-all for the single-precision run via the existing conditional:

TEST_ALL: ${{ matrix.mpi == 'mpi' && '--test-all' || '' }}

Before this PR, the single-precision entry had mpi: no-mpi, so TEST_ALL evaluated to '' and the test command ran only the default subset. After this change, TEST_ALL becomes '--test-all', so the effective test command becomes:

/bin/bash mfc.sh test -v --max-attempts 3 -j $(nproc) $ONLY_CHANGES --test-all --single

This is a substantially larger test scope than before. If the intent was only to add --single precision flag coverage with MPI, verify that running the full --test-all suite in this job is also desired — if not, the TEST_ALL condition should be updated to decouple MPI presence from full-suite execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Single/modular precision fix ups

1 participant