Fix guess_TopologyAttrs for empty Elements and Atomtypes#5416
Open
AnimeshPriyanshu wants to merge 1 commit into
Open
Fix guess_TopologyAttrs for empty Elements and Atomtypes#5416AnimeshPriyanshu wants to merge 1 commit into
AnimeshPriyanshu wants to merge 1 commit into
Conversation
Author
|
AnimeshPriyanshu
force-pushed
the
fix-5414-missing-value-label
branch
from
2ee98ed to
4c1cd4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5414
Changes made in this Pull Request
missing_value_label = ""toElementsandAtomtypesso empty string values are recognized as missing during topology attribute guessing.Atomtypespartial guessing test to reflect the new behavior.LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.