Skip to content

Fix: replace hardcoded logger names with __name__ (fixes #5369)#5411

Closed
Dev-aaditya wants to merge 1 commit into
MDAnalysis:developfrom
Dev-aaditya:fix/logger-use-dunder-name
Closed

Fix: replace hardcoded logger names with __name__ (fixes #5369)#5411
Dev-aaditya wants to merge 1 commit into
MDAnalysis:developfrom
Dev-aaditya:fix/logger-use-dunder-name

Conversation

@Dev-aaditya

Copy link
Copy Markdown

Fixes #5369

Changes made in this Pull Request:

  • Replaced 27 hardcoded string arguments to logging.getLogger() with __name__, following the official Python logging recommendation (https://docs.python.org/3/howto/logging.html#advanced-logging-tutorial).
  • As a side effect, fixed several pre-existing logger naming bugs caused by typos/drift between the hardcoded string and the actual module path (e.g. coordinates/PDB.py was registered as "MDAnalysis.coordinates.PBD", analysis/rms.py as "MDAnalysis.analysis.rmsd").
  • Added CHANGELOG entry and added my name to AUTHORS.

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes

PR Checklist

  • Issue raised/referenced?
  • Tests updated/added?
  • Documentation updated/added?
  • package/CHANGELOG file updated?
  • Is your name in package/AUTHORS? (If it is not, add it!)
  • LLM/AI disclosure was updated.

Developers Certificate of Origin

I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.85%. Comparing base (941d679) to head (57ac31d).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5411   +/-   ##
========================================
  Coverage    93.85%   93.85%           
========================================
  Files          182      182           
  Lines        22509    22509           
  Branches      3202     3202           
========================================
  Hits         21125    21125           
  Misses         922      922           
  Partials       462      462           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @Dev-aaditya I'm going to block and reject this PR.

My reason is that this PR attempts to put 380k lines of code (which seems to be caused by an attempt to push all the Cython generated files) and you are, by your own admission, using an LLM to generate code (which is disccouraged by the MDAnalysis AI policy).

With these two issues combined, this PR is not in a reviewable state and so we will reject it.

@IAlibay

IAlibay commented Jun 29, 2026

Copy link
Copy Markdown
Member

Closing as not adhering to contribution standards.

@IAlibay IAlibay closed this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logging.getLogger() should follow a standardized syntax.

2 participants