You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[info] waiting for server...
[warn] slimeweb did not come up for echo-ws; skipping
Hey @MDA2AV , can you tell me how you’re checking whether the echo-ws server is up or not? In all three cases, it’s showing the same log. I thought there was an issue with the ping-pong frames, so I fixed that, but the problem still persists. Since it passed validation phase, I’m a bit confused.
The readiness check is just curl -s -o /dev/null --max-time 2 http://localhost:8080/ws looped for 30s. It accepts any HTTP response code. It sounds like your /ws handler closes the socket on a plain GET (no Upgrade: websocket header) instead of returning an HTTP error. Have it return a 400 or 426 on non-upgrade requests and the probe will pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping to see few more RPS than previous run.