update mq-bridge, add crud, fortunes - #1312
Draft
marcomq wants to merge 15 commits into
Draft
Conversation
Contributor
Author
|
/benchmark -f mq-bridge |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark -f mq-bridge --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
| //! endpoints degrade rather than blocking the cleartext profiles. | ||
|
|
||
| #[global_allocator] | ||
| static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc; |
Collaborator
There was a problem hiding this comment.
Not so sure but this seems to be more of a tuned change to me. I am not too much into Rust and mimalloc seems stable enough to ship to production, so I guess this is fine - just a thing to consider maybe.
Contributor
Author
There was a problem hiding this comment.
Hm. Yes - this is probably alredy a tuned setup. Mimalloc isn't completely standard - even if stable.
I mostly oriented on the trillium setup. It is also using mimalloc. Also in the not tuned version:
https://github.com/MDA2AV/HttpArena/blob/main/frameworks/trillium/src/main.rs#L2
Contributor
Author
There was a problem hiding this comment.
So - I just removed mimalloc. Will check via bench if this makes a big difference.
Anyway - if this is an issue, trillium should probably also remove mimalloc.
Contributor
Author
|
/benchmark -f mq-bridge |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
MDA2AV
force-pushed
the
update/mq-bridge
branch
from
August 26, 2026 18:12
5ee0aa4 to
d9c32e5
Compare
marcomq
force-pushed
the
update/mq-bridge
branch
from
August 26, 2026 20:01
d9c32e5 to
74755ac
Compare
Owner
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
Using Edit: Checking again - mimalloc also significantly increased memory consumption. So - it was probably better for throughput, but not good for the final resulted score. Will evaluate - I think I will make a lib change to improve performance without mimalloc. |
marcomq
marked this pull request as draft
August 27, 2026 06:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating mq-bridge to latest version.
PR Commands — comment on this PR to trigger (requires collaborator approval):
/benchmark -f <framework>/benchmark -f <framework> -t <test>/benchmark -f <framework> --save/benchmark -f <framework> -t <test> --save/benchmark -f <framework> --compare <other>/benchmark-multiple -f <fw1>,<fw2>,...-tand--savetoo; saved results land in a single commit/benchmark-multiple --save-fneeded: benchmark and save every framework the PR touches/benchmark-test -t <test><test>and save the resultsFor
/benchmark, always specify-f <framework>; the flags combine in any order. Results come back as a comment with a per-profile table of RPS, p99, CPU and memory — one table per framework on multi runs. A new benchmark comment while a run is in flight queues behind it (one deep) instead of cancelling it. For multi-framework PRs (dependency bumps, same-language refactors) prefer/benchmark-multiple, which runs everything in a single job and commits all saved results together, so no run overwrites another.--compareworks on single-framework runs only.What the deltas are measured against. By default, this framework's own results published on
main- answering "did this change help?". When you are tuning a variant or a successor entry,--comparere-bases them on another entry instead:The reply states which baseline it used, and profiles the other framework does not run show
n/arather than a delta.Run benchmarks locally
You can validate and benchmark your framework locally with the lite script — no CPU pinning, fixed connection counts, all load generators run in Docker.
Requirements: Docker Engine on Linux. Load generators (gcannon, h2load, h2load-h3, wrk) are built as self-contained Docker images on first run.