Support persistent performance modes and surface events on Android#49
Open
acedmicabhishek wants to merge 5 commits into
Open
Support persistent performance modes and surface events on Android#49acedmicabhishek wants to merge 5 commits into
acedmicabhishek wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: ce4ee32 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
the solution has to be provided first from dotlottie-android release to review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had major issue with this stuff bro on god no cap
In complex React Native applications, frequent navigation can lead to dropped frames or "invisible icons" due to the constant re-parsing of heavy Lottie JSON models. To resolve this, this PR exposes new high-performance features for Android, allowing developers to directly optimize animation responsiveness and lifecycle handling.
When combined with the companion updates in the
dotlottie-androidcore, this provides a robust, native-level solution for achieving "premium" animation performance.I have made the pull on that repo too
both of them needs to be merged
New Features & API Updates
performanceModeProp: Allows developers to switch betweenram(default) andcpumodes. Activatingcpumode keeps the underlying C++ player alive in a native cache, successfully eliminating re-parsing overhead during screen transitions.cacheIdProp: Introduces a unique identifier for caching specific player instances in native memory. This is especially critical for maintaining smooth performance in persistent UI elements like Bottom Navigation Bars.onSurfaceReadyEvent: Added a new bubbling event that instantly notifies the JavaScript thread the moment the native OpenGL surface is fully bound and ready to render, enabling perfect synchronization for initial animations.PERFORMANCE.mdguide and updated theREADMEto clearly explain these optimizations to developers.NOTE : LOOK BRO I KNOW YALL GOATED AND SMART BUT IDK WHY IM SAYING THIS , ONCE Y'ALL MERGE IT
UPDATE THE GRADLE FILE , IT CURRENTLY HOOK TO MY OTHER FORK OF
DOTLOTTIE-ANDROIDBECAUSE BOTH NEEDS TO BE MERGED , BECAUSE THIS FEATURE IS TOTALLY DEPENDENT ON THEDOTLOTTIE-ANDROID