Skip to content

chore: standardize github download labels#41

Merged
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
eduardomozart:feat/refactor-clients-v2
Jul 5, 2026
Merged

chore: standardize github download labels#41
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
eduardomozart:feat/refactor-clients-v2

Conversation

@eduardomozart

@eduardomozart eduardomozart commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR standardizes the client download labels across the app directory.

Specifically, it updates generic "Download" labels to "Download on GitHub" for clients hosted on GitHub (such as Moonlight Embedded, 3DS, TV, and Wii U). This brings them inline with the existing convention already used by other GitHub-hosted clients (like Qt, Switch, Tizen, and Vita), ensuring a consistent and clear user experience on the Sunshine clients page.

Screenshot

image

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@eduardomozart
eduardomozart force-pushed the feat/refactor-clients-v2 branch from 8c0b640 to 2ddbb0c Compare July 5, 2026 17:52
@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

@ReenigneArcher

Copy link
Copy Markdown
Member

I was rather intentional about some of them saying "Download" versus "Download on GitHub".

The ones that say "Download on GitHub" go to the releases page, while the others go to instructions on how to install/download.

@ReenigneArcher

Copy link
Copy Markdown
Member

I was rather intentional about some of them saying "Download" versus "Download on GitHub".

The ones that say "Download on GitHub" go to the releases page, while the others go to instructions on how to install/download.

Though, I guess this will be easier to maintain.

@ReenigneArcher
ReenigneArcher merged commit 11f3505 into LizardByte:master Jul 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants