Skip to content

Update function parameters from 'parameters' to 'attributes' #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s22-tech wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update function parameters from 'parameters' to 'attributes' #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions public_html/storage/addons/pages/vmod.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,22 +121,22 @@
<operation method="after" type="multiline" onerror="warning">
<find><![CDATA[
case 'language':
return form_select_language($name, $input, $parameters);
return form_select_language($name, $input, $attributes);
]]></find>

<insert><![CDATA[
case 'page':
return form_select_page($name, $input, $parameters);
return form_select_page($name, $input, $attributes);
]]></insert>
</operation>

<operation method="before" type="multiline" onerror="warning">
<find><![CDATA[
function form_select_timezone($name, $input=true, $parameters='') {
function form_select_timezone(string $name, bool|array|string $input=true, array|string $attributes=[]): string {
]]></find>

<insert><![CDATA[
function form_select_page($name, $input=true, $parameters='') {
function form_select_page($name, $input=true, $attributes='') {

$iterator = function($parent_id, $level) use (&$iterator) {

Expand Down Expand Up @@ -174,10 +174,10 @@
$options = $iterator(0, 1);

if (preg_match('#\[\]$#', $name)) {
return form_select_multiple($name, $options, $input, $parameters);
return form_select_multiple($name, $options, $input, $attributes);
} else {
array_unshift($options, ['', '-- '. t('title_select', 'Select') . ' --']);
return form_select($name, $options, $input, $parameters);
return form_select($name, $options, $input, $attributes);
}
}
]]></insert>
Expand Down