refactor(match2): grid-based matchsummary to widget3

[ElectricalBoy]

How did you test this change?

dev in AoE / LoL

[hjpalpha]

what does the "impl" stand for?

[ElectricalBoy]

implementation

[Copilot]

Pull request overview

Refactors match summary rendering to the Widget3 component model by converting the shared GameRow implementation to a component factory and updating multiple wiki-specific MatchSummary.lua modules to use the new createComponent API.

Changes:

• Converted Widget/Match/Summary/GameRow from a class-based widget to a Widget3 component factory (createComponent) with an impl table.
• Updated multiple game wikis’ MatchSummary implementations to use GameRow.createComponent and the new static helpers (mapDisplay, lengthDisplay, scoreDisplay).
• Tightened/standardized CSS prop typing via HtmlStyleProps and updated HTML widget usage (Html/All → Html) where touched.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
lua/wikis/valorant/MatchSummary.lua	Migrates Valorant match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/rainbowsix/MatchSummary.lua	Migrates Rainbow Six match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/overwatch/MatchSummary.lua	Migrates Overwatch match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/mobilelegends/MatchSummary.lua	Migrates Mobile Legends match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/leagueoflegends/MatchSummary.lua	Migrates LoL match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/identityv/MatchSummary.lua	Migrates IdentityV match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/honorofkings/MatchSummary.lua	Migrates HoK match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/dota2/MatchSummary.lua	Migrates Dota 2 match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/deadlock/MatchSummary.lua	Migrates Deadlock match summary row to GameRow.createComponent and Widget3 return types.
lua/wikis/counterstrike/MatchSummary.lua	Updates Counter-Strike row override to the new scoreDisplay calling convention.
lua/wikis/ageofempires/MatchSummary.lua	Migrates AoE match summary row to GameRow.createComponent and Html module usage.
lua/wikis/commons/Widget/Match/Summary/GameRow.lua	Core refactor: introduces createComponent, moves helpers to static functions, updates rendering to Widget3.
lua/wikis/commons/Widget/Match/Summary/GameCenter.lua	Updates CSS prop typing to HtmlStyleProps.
lua/wikis/commons/Widget/Component.lua	Introduces HtmlStyleProps alias for consistent CSS typing.

Comments suppressed due to low confidence (5)

lua/wikis/overwatch/MatchSummary.lua:43

• Returning a table literal here can create a non-array table when optional widgets (Mvp/CharacterBanTable) return nil. MatchSummary/Base later calls WidgetUtil.collect on the result; if the table has gaps, Array.isArray() is false and rendering can break. Build the list without gaps (e.g., start with {GamesContainer} and append optional elements via table.insert).

	return {
		MatchSummaryWidgets.GamesContainer{
			children = Array.map(match.games, function (game, gameIndex)
				if Logic.isEmpty(game.map) then
					return

lua/wikis/mobilelegends/MatchSummary.lua:54

• Returning a table literal here can create a non-array table when optional widgets (Mvp/CharacterBanTable) return nil. MatchSummary/Base later passes createBody() into WidgetUtil.collect; if Array.isArray() is false due to gaps, the raw table is inserted and can break rendering. Build the body list incrementally (table.insert) so nil entries are skipped and the result remains a proper array.

	return {
		MatchSummaryWidgets.GamesContainer{
			children = Array.map(match.games, function (game, gameIndex)
				if Logic.isEmpty(game.length) and Logic.isEmpty(game.winner) and not hasCharacterData(game) then
					return

lua/wikis/identityv/MatchSummary.lua:50

• Returning a table literal here can create a non-array table when optional widgets (Mvp/MapVeto/CharacterBanTable) return nil. MatchSummary/Base later wraps the body via WidgetUtil.collect; if Array.isArray() is false due to gaps, the raw table is inserted and can break rendering. Build the body list incrementally (table.insert) so nil entries are skipped and the result remains a proper array.

	return {
		MatchSummaryWidgets.GamesContainer{
			children = Array.map(match.games, function (game, gameIndex)
				if not game.map and not CustomMatchSummary.hasScores(game) then
					return

lua/wikis/honorofkings/MatchSummary.lua:54

• Returning a table literal here can create a non-array table when optional widgets (Mvp/CharacterBanTable) return nil. MatchSummary/Base later passes this into WidgetUtil.collect; if Array.isArray() is false due to gaps, the raw table is inserted and can break rendering. Build the body list without gaps (e.g., start with {GamesContainer} and append optional elements via table.insert).

	return {
		MatchSummaryWidgets.GamesContainer{
			children = Array.map(match.games, function (game, gameIndex)
				if Logic.isEmpty(game.length) and Logic.isEmpty(game.winner) and not hasCharacterData(game) then
					return

lua/wikis/deadlock/MatchSummary.lua:50

• Returning a table literal here can create a non-array table when optional widgets (CharacterBanTable) return nil. MatchSummary/Base later passes this into WidgetUtil.collect; if Array.isArray() is false due to gaps, the raw table is inserted and can break rendering. Build the body list without gaps (e.g., start with {GamesContainer} and append optional elements via table.insert).

	return {
		MatchSummaryWidgets.GamesContainer{
			children = Array.map(match.games, function (game, gameIndex)
				if game.status == STATUS_NOT_PLAYED then
					return

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.