feat(Match2): Enable FFA on Tarkov Arena#7681
Open
Hesketh2 wants to merge 8 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
* feat: Enable FFA on tarkovarena * Add FFA copypasta * chore: update visual snapshots * chore: update visual snapshots * Update lua/wikis/tarkovarena/MatchSummary/Ffa.lua Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> * Update Ffa.lua --------- Co-authored-by: mbergen <16326643+mbergen@users.noreply.github.com> Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
mbergen
changed the title
but it doesnt seem to make visual errors so I'll leave it as is
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Free-For-All (FFA) Match2 support on the Tarkov Arena wiki by adding an FFA match summary module, extending MatchGroup input parsing to handle FFA matches, and updating the match code copy-paste generator to emit FFA match markup when there are more than two opponents.
Changes:
- Added
MatchSummary/Ffa.luaimplementation for rendering FFA match summaries via the shared commons FFA widgets/base helper. - Extended
MatchGroup/Input/Custom.luato pass an FFA parser intostandardProcessMatchand implement FFA map extraction + scoring. - Updated
GetMatchGroupCopyPaste/wiki.luato generate FFA-style{{Match}}code whenopponents > 2.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/wikis/tarkovarena/MatchSummary/Ffa.lua | Adds an FFA match summary entrypoint for Match2 using the shared FFA summary base/widgets. |
| lua/wikis/tarkovarena/MatchGroup/Input/Custom.lua | Adds FFA parsing/scoring support by wiring in an FfaMatchFunctions parser. |
| lua/wikis/tarkovarena/GetMatchGroupCopyPaste/wiki.lua | Generates appropriate Match2 copy-paste output for both standard and FFA matches based on opponent count. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+21
| ---@param props {bracketId: string, matchId: string} | ||
| ---@return Widget | ||
| function CustomMatchSummary.getByMatchId(props) |
Comment on lines
+22
to
+23
| ---@class FFAMatchGroupUtilMatch | ||
| local match = MatchGroupUtil.fetchMatchForBracketDisplay(props.bracketId, props.matchId) |
Comment on lines
+75
to
+80
| Array.map(Array.range(1, bestof), function(mapIndex) | ||
| return INDENT .. '|map' .. mapIndex .. '={{Map|map=|date=|finished=|vod=}}' | ||
| end), | ||
| Array.map(Array.range(1, opponents), function(opponentIndex) | ||
| return INDENT .. '|opponent' .. opponentIndex .. '=' .. WikiCopyPaste.getFfaOpponent(mode, bestof) | ||
| end), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the wiki does not have any FFA-type events so MGI for this wiki removes that originally, now they did start having it so I'm reworking this setup by just clean re-pasting the entire Lab setup again.
How did you test this change?
LIVE