Update admin-bar.blade.php: Fix uncaught TypeError for missing confirmationLink element on non-admin views#994
Open
thealexparadox wants to merge 1 commit into
Open
Conversation
Fix null reference error for confirmationLink on pages without admin bar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request resolves a runtime
TypeError(can't access property "addEventListener", document.getElementById(...) is null) occurring on pages where the admin bar module is conditionally absent.Root Cause
The inline script block inside
admin-bar.blade.phpunconditionally executesdocument.getElementById("confirmationLink").addEventListener(...)and attempts to read its attributes on every page load. When rendered on views lacking the administrative user deletion link,#confirmationLinkevaluates tonull, breaking client-side JavaScript execution globally for the UI.Solution
if (confirmationLink)) around the event listener binding logic.showConfirmation()helper function to safely verify element presence before attempting to fetch thehrefattribute.