feat(core): report scenario override outcomes - #6
Open
92Infinitus92 wants to merge 8 commits into
Open
Conversation
92Infinitus92
force-pushed
the
feat/scenario-override-outcomes
branch
2 times, most recently
from
August 17, 2026 09:02
291cabf to
3601a68
Compare
There was a problem hiding this comment.
92Infinitus92 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Collaborator
92Infinitus92
force-pushed
the
feat/scenario-override-outcomes
branch
from
August 21, 2026 13:54
eae563d to
c4da86e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR adds typed outcomes for scenario overrides and exposes outcome-aware registration and time travel through RPC and the Node SDK. It also makes schedule updates and persistent override materialization transactional.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Time-travel request] --> B[Validate target slot] B --> C{Pending override strictly between current and target?} C -- Yes --> D[Return invalid-params error] C -- No --> E[Materialize current-slot overrides] E --> F{Target differs from current?} F -- Yes --> G[Confirm current block] G --> H[Materialize next-slot overrides] F -- No --> K[Apply target clock] H --> I{Target later than next slot?} I -- Yes --> J[Materialize target-slot overrides] I -- No --> K J --> K K --> L[Return epoch info and override outcomes]Reviews (11): Last reviewed commit: "fix(core): reset state after scenario pl..." | Re-trigger Greptile