app: state-routed open for table rows and rail — fixes silent read-only comments#35
Merged
Merged
Conversation
Row double-click/Enter and the rail's Open review called navigateToDiff directly, skipping the Pending -> InReview transition the card action performs — and DiffView only enables click-to-comment while InReview, so reviews opened from the table landed silently read-only. Opens now route by gate state exactly like the action button; the rail's finding jump does the same since jumping to a line is a prelude to commenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regression from #31's open semantics, caught live: opening a review via table row double-click/Enter or the preview rail's "Open review →" used a bare
navigateToDiff, skipping the Pending → InReview transition the card's Review button performs.DiffViewonly enables click-to-comment while the gate is InReview, so those paths landed in a silently read-only diff — "comments are not working."Opens from the table and rail now route by gate state exactly like the action button (Pending/Reworked →
openReview, everything else → navigate). The rail's finding Jump does the same, since jumping to a line is a prelude to commenting on it.Verified
tscclean ·vitest391 ·vite buildok. Manual check after merge: open a Pending PR from the table via double-click → gate pill reads IN REVIEW → clicking a line number opens the comment box.🤖 Generated with Claude Code