Fix: OpenGraph default logo and job page image - #345
Open
arthurcaccavo wants to merge 3 commits into
Open
Conversation
Member
the image has changed path but this address was not updated, causing the default og image not to load Signed-off-by: arthurcaccavo <contato@arthurcaccavo.dev.br>
LINK: LibreCodeCoop#228 (comment) Signed-off-by: arthurcaccavo <contato@arthurcaccavo.dev.br>
Signed-off-by: arthurcaccavo <contato@arthurcaccavo.dev.br>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #228. Most of the discussion is on the referenced issue, but to sum it up:
Extra
Extra extra:
Facebook's Open Graph Requirements documentation recommends the image to be 1200 x 630 and at least 600 x 315 pixels. The current available image is 552 x 316, which is smaller than the minimum size. I will open an issue requesting for a 1200 x 630 to be added, and I can follow up to update the default.
Reference