docs: fix clone URL and directory in README setup instructions - #90
Open
mateuscgoncalves wants to merge 1 commit into
Open
docs: fix clone URL and directory in README setup instructions#90mateuscgoncalves wants to merge 1 commit into
mateuscgoncalves wants to merge 1 commit into
Conversation
Contributor
|
@mateuscgoncalves is attempting to deploy a commit to the mythie's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If we follow the README steps as written:
git clone https://github.com/libpdf/core.git cd libpdfWe face two issues:
LibPDF-js, notlibpdf:git clonecreates acore/directory, socd libpdffails as well.Fix
This is the first command a new contributor runs, so it currently blocks onboarding and contradicts Development Setup section in
CONTRIBUTING.md, which already usesLibPDF-js/coreandcd core.Note: this README is also on npm, so the fix will propagate there on the next release