Streamline Editor Architecture: Sheet Ordering, UI Lookup, and UnitUi Factory#87
Open
CG-Tespy wants to merge 3 commits intoLexianDEV:masterfrom
Open
Streamline Editor Architecture: Sheet Ordering, UI Lookup, and UnitUi Factory#87CG-Tespy wants to merge 3 commits intoLexianDEV:masterfrom
CG-Tespy wants to merge 3 commits intoLexianDEV:masterfrom
Conversation
…i | Bugfix Bug(s) fixed: - Moving top-level elements in the EventSheet ui not sticking correctly Other Notes: - Had FKUnitUi's nodes specify that they're passing FKUnitUis, since that's the only thing that should be passed when emitting those signals - And it can help listeners, too - BlockContainerUi class_name -> FKBlockContainerUi
… own ordered_items list | Used FKCondition duplication func
# Conflicts (resolved): # addons/flowkit/editor/editor_globals.gd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
Moves responsibilities from FKMainEditor → FKEventSheet
This consolidates all sheet‑structure logic into the sheet itself, where it belongs.
Moves responsibilities from FKMainEditor → FKBlockContainerUi
This makes the container the authoritative source for UI‑side block order and lookup.
Introduces a new class: FKUnitUiFactory
This removes UI instantiation logic from FKMainEditor and centralizes it in a dedicated factory.
Small Improvements
Bugfix(es)