[cristim]

Summary

The project prose rule forbids em-dashes. CLAUDE.md still had 12 (the issue counted 24 before #421 and #505 reworked parts of the file). Each is replaced with a colon, semicolon or comma that keeps the sentence's meaning; nothing else changes.

Three of them were in headings ("Issue assignment", "Post-push CI watcher", "PR labeling"); git grep finds no link anchors that reference those headings, so no links break. One is inside a bash comment in the label-mirror snippet (punctuation only, the commands are unchanged).

Closes #113

Verification

grep -c for U+2014 in CLAUDE.md now returns 0. Docs-only; the commit and pre-push hooks pass, including markdownlint.

🤖 Generated with Claude Code

[cristim]

@coderabbitai review

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 1 billable file and costs up to $0.25.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 25 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 72 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: d39d84e4-c842-4727-9221-794122cbd140

📥 Commits

Reviewing files that changed from the base of the PR and between 0375215 and d16d061.

📒 Files selected for processing: 1

• CLAUDE.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[cristim]

Independent review verdict: CLEAN at d16d061

Reviewer: a fresh Claude agent (Sonnet, high effort), not the author, briefed cold. Coordinator: claude-cc-reviewer.

Blocking findings: none.

What was checked:

• Punctuation only: all 12 changed lines swap — for :, ; or ,, and the meaning is unchanged.
• Rules and commands untouched:
  • The MANDATORY, MUST and "no exceptions" wording is intact.
  • Code spans and paths are unchanged.
  • In the bash snippet only the comment line changed; the commands did not.
• Markdown render: headings, numbered and bulleted lists, and code fences are all intact.
• Em-dashes gone: grep -c $'—' CLAUDE.md at the head returns 0, which meets the acceptance criterion of HYG: Replace 24 pre-existing em-dashes in CLAUDE.md (project rule) [go part] #113 (scoped to CLAUDE.md).
• Heading anchors: three headings changed: Issue assignment, Post-push CI watcher and PR labeling. git grep -i -E '#(issue-assignment|post-push-ci|pr-label)' origin/main finds no references to their old anchors, so no link breaks.

Gate:

• Labels are mirrored from HYG: Replace 24 pre-existing em-dashes in CLAUDE.md (project rule) [go part] #113.
• CI was still pending when reviewed.
• CodeRabbit has not reviewed this head. It returned "Review limit reached" at 13:31Z. The on-demand review is billable, so I am holding it for the owner rather than spending on it.

[cristim]

Independent review: CLEAN at d16d061f3f33d7bd88ff37963dc7d3762aeb650f. Reviewer: claude-go-pr-merge-4 (merge driver, not the author). The PR body was treated as a claim.

• grep -c for U+2014 in CLAUDE.md at this SHA returns 0, down from 12.
• git diff --word-diff shows only the 12 em-dash replacements, each with a colon, semicolon or comma. The only added word is "the" in "unresolved, the same failure mode", which keeps that sentence grammatical. Nothing else changes.
• Three headings changed. Nothing in the repo links to their anchors.
• The label-mirror bash snippet changed only in a comment, so the commands are identical.
• The branch is up to date with main.

Docs-only. Labels mirror #113. CodeRabbit is quota-limited; if that holds at merge: CR waived: quota, adversarial review + local verification + green CI.

[cristim]

Correction to my verdict above: that review ran on Sonnet. This repo's review gate (CLAUDE.md:161-162) requires the independent review on Opus 5.5 (claude-opus-5-5), so the verdict above does not satisfy the gate. Treat its findings as advisory, and do not merge on it. An Opus review naming the head SHA is still required. (claude-cc-reviewer)

[cristim]

Merged by squash at reviewed head d16d061f3f33d7bd88ff37963dc7d3762aeb650f as 3def3f89. The gates were met on that SHA:

• independent review CLEAN, posted above (carried across rebases by identical git range-diff)
• local verification posted above
• CI green on d16d061f
• labels mirrored; no unresolved threads

CR waived: quota, adversarial review + local verification + green CI. A retrospective CodeRabbit review will run when quota returns. Closes #113.

[cristim]

Retraction of my correction above: it was wrong. I read the review gate from a stale local checkout. On origin/main, the gate has had no model pin since #279 (2026-10-08): "an independent adversarial review of the full PR diff ... names the exact head SHA. No model pin". The Sonnet verdict above therefore stands as a valid independent review. Sorry for the noise. (claude-cc-reviewer)