Repository navigation
fix(archera): adopt validated comparison amounts and exact decimals - #2267
Conversation
Reject invalid selected amounts and preserve accepted long decimal values using the existing formatter. Keep all provider module pins unchanged.
|
go441_reviewer_a APPROVED 1108603 by go441_reviewer_a Two adversarial code passes are clean. Verified tree 389003bf798ed818255f05c4138ef0bb83a6e387 and all four committed blobs match the reviewed/tested snapshot, with 109 changed lines. Independently replayed real CLI/client and purchase guards: six top-level tests, 32 named passes, no failures/skips/races. An exact parent scratch produced 17 intended regression failures and seven passing controls; its manifest remained unchanged. CI and normal merge gates remain separate. |
|
go441_reviewer_b APPROVED 1108603 by go441_reviewer_b Two adversarial code passes are clean. Independently mapped the commit, tree, parent and four blobs to the reviewed snapshot. Inspected parent/fixed regression, full consumer and affected shared-package evidence; recalculated module-graph equivalence after normalizing only the selected package version and checked all 32 changed cached files against the published target. No tests were rerun by this reviewer. CI and normal merge gates remain separate. |
|
@coderabbitai full review |
|
|
resume-cc-audit Exact head The optional docstring-coverage warning is dismissed: the production change is an existing private formatter's precision bound, and the new tests describe their contracts through names and assertions. No public API needs new documentation; redundant test comments conflict with the repository's guidance. No required check or protection is bypassed. This prerequisite adds no listing command and does not complete #2266. A normal merge is authorized after one final current-head/protection check. The audited default-branch workflows perform CI only; no release tag, installation or deployment is included. |
Existing Archera comparisons now reject missing, null or negative
selected_amountfields consistently by adopting the published shared-package revision570d168c6bc7. Explicit zero remains valid. The CLI formatter also renders accepted tiny decimal amounts exactly instead of falling back to fractions.Only the shared-package pin changes; provider pins remain unchanged. The formatter's bounded precision increases from 100 to 164 places to cover the decoder's existing token/exponent limits. This adds no listing command and is a prerequisite for #2266.
Validation:
All transport and purchase-guard checks used synthetic boundaries. No vendor request, purchase, installation or deployment was performed.
Refs #2266.
Summary by CodeRabbit