fix: resolve package roots to output paths#476
Open
kikiminyes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
When a package-root alias resolved through
packageId.subModuleName, the transformer used the source package directory as the module output directory. In declaration output withoutDir, that could emit paths back to the source tree instead of the generated declaration tree.This keeps package-root imports based on the resolved source file's emitted output directory, then trims any implicit package subpath such as
subdir/main.d.tsso existing package-main behavior stays intact.Validation:
../../../../../packages/componentsbefore this fix.outDir.yarn compileyarn testyarn prettier --check src/utils/resolve-module-name.ts test/tests/project-ref.test.ts test/projects/project-ref/tsconfig.base.json test/projects/project-ref/b/tsconfig.json test/projects/project-ref/b/deep/package-root.ts test/projects/project-ref/b/packages/pkg-root/index.ts test/projects/project-ref/b/packages/pkg-root/package.jsonyarn eslint src/utils/resolve-module-name.ts test/tests/project-ref.test.ts test/projects/project-ref/b/deep/package-root.ts test/projects/project-ref/b/packages/pkg-root/index.ts