Skip to content

fix(examples): send-task errors print OFT: undefined when --oft-address is omitted #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boleklebovski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(examples): send-task errors print OFT: undefined when --oft-address is omitted #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/quiet-otters-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@layerzerolabs/lzapp-migration-example": patch
"@layerzerolabs/mint-burn-oft-adapter-example": patch
"@layerzerolabs/native-oft-adapter-example": patch
"@layerzerolabs/oft-adapter-example": patch
"@layerzerolabs/oft-solana-example": patch
"@layerzerolabs/oft-upgradeable-example": patch
"@layerzerolabs/ovault-evm-example": patch
---

Omit the `OFT:` fragment from send-task error messages when `--oft-address` is not supplied, instead of printing `OFT: undefined`.
2 changes: 1 addition & 1 deletion examples/lzapp-migration/tasks/evm/v1/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
2 changes: 1 addition & 1 deletion examples/lzapp-migration/tasks/solana/sendSolana.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export async function sendSolana({
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
6 changes: 3 additions & 3 deletions examples/mint-burn-oft-adapter/tasks/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down Expand Up @@ -216,7 +216,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand All @@ -229,7 +229,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_SENDING_TRANSACTION,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
6 changes: 3 additions & 3 deletions examples/native-oft-adapter/tasks/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down Expand Up @@ -271,7 +271,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand All @@ -298,7 +298,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_SENDING_TRANSACTION,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
6 changes: 3 additions & 3 deletions examples/oft-adapter/tasks/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down Expand Up @@ -216,7 +216,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand All @@ -229,7 +229,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_SENDING_TRANSACTION,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
6 changes: 3 additions & 3 deletions examples/oft-solana/tasks/evm/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down Expand Up @@ -114,7 +114,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand All @@ -127,7 +127,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_SENDING_TRANSACTION,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
2 changes: 1 addition & 1 deletion examples/oft-solana/tasks/solana/sendSolana.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export async function sendSolana({
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
6 changes: 3 additions & 3 deletions examples/oft-upgradeable/tasks/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down Expand Up @@ -216,7 +216,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand All @@ -229,7 +229,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_SENDING_TRANSACTION,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down
6 changes: 3 additions & 3 deletions examples/ovault-evm/tasks/sendEvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_GETTING_HRE,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down Expand Up @@ -231,7 +231,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_QUOTING_NATIVE_GAS_COST,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand All @@ -254,7 +254,7 @@ export async function sendEvm(
} catch (error) {
DebugLogger.printErrorAndFixSuggestion(
KnownErrors.ERROR_SENDING_TRANSACTION,
`For network: ${endpointIdToNetwork(srcEid)}, OFT: ${oftAddress}`
`For network: ${endpointIdToNetwork(srcEid)}${oftAddress ? `, OFT: ${oftAddress}` : ''}`
)
throw error
}
Expand Down