Make materialized query more helpful - #8000
Open
labkey-jeckels wants to merge 1 commit into
Open
Conversation
2 tasks
labkey-nicka
approved these changes
Aug 31, 2026
labkey-nicka
left a comment
labkey-nicka
left a comment
Contributor
There was a problem hiding this comment.
Main thing to test is that this analyze does not take exceedingly long to execute for large tables.
| } | ||
|
|
||
| static final BlockingCache<String,_MaterializedQueryHelper> _materializedQueries = CacheManager.getBlockingStringKeyCache(CacheManager.UNLIMITED, CacheManager.HOUR, "materialized sample types", null); | ||
| // TTL is a backstop for missed invalidations. Admins can manually clear via Admin Console->Caches |
Contributor
There was a problem hiding this comment.
nit: Comment is true for all of our caches. I feel its not worth mentioning here.
| } | ||
| } | ||
|
|
||
| /** SELECT INTO leaves the table with no statistics, so the planner guesses until autovacuum eventually analyzes it. */ |
Contributor
There was a problem hiding this comment.
Well, TIL that running ANALYZE after SELECT INTO or CREATE TABLE AS is considered standard practice in Postgres.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Analysis shows that our current 1 hour retention for materialized tables is way too short for sample type scenarios. Additionally, without doing an analyze the DB may not be making good query plan choices.
Changes
ANALYZEmaterialized table as part of its creationTasks