Removing obsolete code that was hitting a deleted table#7688
Open
labkey-klum wants to merge 2 commits into
Open
Removing obsolete code that was hitting a deleted table#7688labkey-klum wants to merge 2 commits into
labkey-klum wants to merge 2 commits into
Conversation
labkey-jeckels
approved these changes
May 22, 2026
cnathe
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
A
claudecode analysis revealed a usage that was not detected when we initially deleted theVisualizationVisitTagtable. It was thought that there might be some reliance on that code in the CDS application but further analysis concluded that no test or product code from that application relies on this.We can safely remove this (and related) code.
Tasks 📍