Skip to content

Prohibit HTTP GET parameters for jsessionid#7676

Merged
labkey-jeckels merged 1 commit into
release26.3-SNAPSHOTfrom
26.3_fb_cookieSessionsOnly
May 23, 2026
Merged

Prohibit HTTP GET parameters for jsessionid#7676
labkey-jeckels merged 1 commit into
release26.3-SNAPSHOTfrom
26.3_fb_cookieSessionsOnly

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels commented May 18, 2026

Rationale

Servers that run both HTTP and HTTPS can end up choosing to send jsessionid values as GET parameters, because they may have an HTTP cookie that set to Secure. In scenarios like this, we want to be sure that we end up redirecting the client to HTTPS. We don't want session IDs to ever leak onto the URL.

Changes

  • Tell Tomcat to only use cookies for communicating sessions

Tasks 📍

  • Claude Code Review
  • Manual Testing @labkey-tchad
    • Configure HTTPS via application.properties
    • Enable a separate HTTP port
    • Don't have HTTP->HTTPS redirect enabled in Site Settings
    • Log in via HTTPS
    • Hit the server via HTTP
    • Ensure you don't see a session on the URL
  • Test Automation
  • Verify Fix

@labkey-jeckels labkey-jeckels added this to the 26.03 milestone May 18, 2026
@labkey-jeckels labkey-jeckels requested a review from a team May 18, 2026 20:32
@labkey-jeckels labkey-jeckels self-assigned this May 18, 2026
@labkey-tchad
Copy link
Copy Markdown
Member

I don't see a jsessionid on the url anymore but I can't actually log in via HTTP. (Yes, require HTTPS is unchecked in site settings)

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

I don't see a jsessionid on the url anymore but I can't actually log in via HTTP. (Yes, require HTTPS is unchecked in site settings)

I think that's the awkward compromise. You can still log in, but only if you're using a browser that doesn't already have the Secure setting on its session cookie.

@labkey-tchad
Copy link
Copy Markdown
Member

I don't see a jsessionid on the url anymore but I can't actually log in via HTTP. (Yes, require HTTPS is unchecked in site settings)

I think that's the awkward compromise. You can still log in, but only if you're using a browser that doesn't already have the Secure setting on its session cookie.

Ok. I tried it in an incognito window but I probably went to HTTPS first and got the secure cookie. I was able to log in if I went straight to HTTP in a fresh incognito window.

@labkey-jeckels labkey-jeckels merged commit f689c93 into release26.3-SNAPSHOT May 23, 2026
8 of 10 checks passed
@labkey-jeckels labkey-jeckels deleted the 26.3_fb_cookieSessionsOnly branch May 23, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants