Build CI against the committed lockfiles - #6
Open
Garfield1002 wants to merge 1 commit into
Open
Conversation
No cargo invocation in either workflow passed --locked, so CI was free to re-resolve and rewrite Cargo.lock instead of failing. A lockfile that no longer matched the manifests still went green, and the versions CI tested were not necessarily the ones recorded in the repository. Pass --locked to every cargo invocation that resolves dependencies, in both workflows. cargo fmt is left alone; it does not resolve anything. This covers crates/qfbvsmtrs/fuzz too, which sits outside the workspace and carries its own Cargo.lock. Both lockfiles are current: all five commands pass with --locked as of this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
good practice :)