Centralize dependencies and package metadata in the workspace - #5
Open
Garfield1002 wants to merge 1 commit into
Open
Centralize dependencies and package metadata in the workspace#5Garfield1002 wants to merge 1 commit into
Garfield1002 wants to merge 1 commit into
Conversation
Each member declared its own versions and its own ../ path dependencies, so a shared dependency had to be edited in several manifests to stay consistent. Move them to [workspace.dependencies] and [workspace.package]; members now carry only what is specific to them. z3 is the case that motivated this: it is a normal dependency of smt-server and a dev-dependency of qfbvsmtrs, both on 0.20.0 with gh-release. Nothing tied the two together, and letting them drift would build and link two different z3 versions. Member crates keep their own `description` and their own feature additions on top of the shared entry, so smt-server still gets qfbvsmtrs with "wire" and rumba-core with "parse", and qfbvsmtrs still takes smt-wire as optional. crates/qfbvsmtrs/fuzz declares its own [workspace] and is therefore outside this one; its path dependency stays as it is, and it is still checked with --manifest-path as CI does. Pure refactor: Cargo.lock is byte-identical, and `cargo tree --workspace --all-features --edges all` is unchanged modulo path prefixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes changing versions easier and removes the odd
../pathpattern