ci: build morph_tests with /bigobj under MSVC to stop recurring C1128 failures - #81
Merged
Conversation
… failures
Three separate branches independently hit MSVC's C1128 ("number of
sections exceeded object file format limit") on test_quantity_forms.cpp
under the cl-debug preset, each after adding only a small amount of new
schema/rule template instantiation. Rather than chase this file by file
as it keeps recurring, /bigobj now applies to the whole morph_tests
target: harmless on Release and on other compilers.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three separate open PRs (issue-cluster-d-util, issue-cluster-i-forms-controller, issue-cluster-k-forms-qml) each independently hit MSVC's C1128 ("number of sections exceeded object file format limit") on
tests/test_quantity_forms.cppunder thecl-debugpreset — every one after adding only a small amount of new schema/rule template instantiation to that file. Each PR needed its own file-scoped/bigobjworkaround to get green.This is a systemic risk, not a one-off: the file is evidently sitting right at MSVC's Debug-build section-count edge, so any future branch that so much as adds one more test case there will hit the same wall.
Fix
Apply
/bigobjto the wholemorph_teststarget (MSVC-only, via$<CXX_COMPILER_ID:MSVC>), rather than chasing individual files as they tip over. Harmless on Release and on non-MSVC compilers.Verification
cl-debuglocally:test_quantity_forms.cpp.objand all other test objects compile and link cleanly.🤖 Generated with Claude Code