Remove wasm url extension check#43
Open
ansbbrooks wants to merge 3 commits into
Open
Conversation
# Conflicts: # src/standalone.js
Contributor
Author
Member
|
I'm fine with the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a wasm url is passed to
createNamespace(),loader.load()checks if the url ends with.gzto handle Gzip archives.This is a problem since urls do not have to have a
.gzextension to serve a Gzip file.For example, running a server that serves the VTK.wasm client
.gzbundle at the following endpoint would fail the url check:It is better to allow the Gzip decompressor to fail on its own if the downloaded resource is not a Gzip archive, and let the user specify what is at the end of their endpoint (since only they can know for sure).
In this PR, the
createNamespace()function has the following signature: