Skip to content

chore(InteractorStyeHDMXR): fix example#3559

Open
Jo-Byr wants to merge 1 commit into
Kitware:masterfrom
Jo-Byr:fix-interactor-style-hdmxr-example
Open

chore(InteractorStyeHDMXR): fix example#3559
Jo-Byr wants to merge 1 commit into
Kitware:masterfrom
Jo-Byr:fix-interactor-style-hdmxr-example

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Context

InteractorStyleHDMXR example throws errors.

Results

The errors are fixed.

Changes

Replaced a failing esm.sh link
Removed non-existing function calls

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

@Jo-Byr
Jo-Byr requested a review from daker July 20, 2026 15:27
@Jo-Byr Jo-Byr self-assigned this Jul 20, 2026
@Jo-Byr

Jo-Byr commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@daker You added calls to getXRSession, onSessionStarted and onSessionEnded in 456f4dd.

These call do not seem to exist or to have existed at any point. I simply replaced getXRSession by a non-null check, which seems to be what is done in vtkWebXRRenderWindowHelper, and simply removed the session start/end calls as they did not seem necessary, tell me if I missed something.

Replace failing esm.sh link
Remove calls to non-existant functions
@Jo-Byr
Jo-Byr force-pushed the fix-interactor-style-hdmxr-example branch from 3bab503 to 7bf4cd0 Compare July 20, 2026 15:30

@daker daker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants