Fix view proxy render window name

[Jo-Byr]

Context

ProxyManager example did not work.

Results

The example is fixed and ViewProxy uses apiSpecificRenderWindow instead of _openGLRenderWindow

Changes

Replace model._openGLRenderWindow by model.apiSpecificRenderWindow in ViewProxy
Fixed argument of render windows' setSize in ProxyManager example

PR and Code Checklist

• semantic-release commit messages
• Run npm run reformat to have correctly formatted code

[finetjul]

Can you please explain why the name of the variable is problem ?

Why not keeping it protected? (with the _ prefix in the name)

[Jo-Byr]

Can you please explain why the name of the variable is problem ?

Why not keeping it protected? (with the _ prefix in the name)

It's not the name directly but the setMacro, there were error thrown due to getApiSpecificRenderWindow not being found.

I removed the '_' to uniformize with other variables but if there is a reason to leave it, I'll put it back.

[finetjul]

Yes, please keep the variable "protected" (to prevent infinite loop).

[finetjul]

It's not the name directly but the setMacro, there were error thrown due to getApiSpecificRenderWindow not being found.

Your commit message should not be "replace openGLRenderWindow by apiSpecificRenderWindow" because

1. it does not bring additional information than reading the diff
2. it does not carry the information about what your commit brings to the "user" (i.e. why should I want that commit)

but instead "fix(ViewProxy): add missing function getApiSpecificRenderWindow()" (or something similar).

[finetjul]

LGTM