Skip to content

refactor(WebGL): remove support for WebGL1#3523

Open
daker wants to merge 1 commit into
Kitware:masterfrom
daker:remove-webgl1
Open

refactor(WebGL): remove support for WebGL1#3523
daker wants to merge 1 commit into
Kitware:masterfrom
daker:remove-webgl1

Conversation

@daker
Copy link
Copy Markdown
Collaborator

@daker daker commented Jun 1, 2026

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Copy Markdown
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it compare with #2212 ?

I find it a bit misleading that claiming it remove WebGL1 support but it still render as in "WebGL1" would do, e.g. it duplicates points for each cells (see vtkCellArrayBufferObject). This is big bottleneck when it comes to rendering initialization and memory usage.

It can be done in a second pass though.

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Jun 3, 2026

@finetjul it's the same as #2212 but rebased. i get your point i will try to see if i can do something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants