Return more KCL outcome data when executing - #1348
Merged
Merged
Conversation
adamchalmers
changed the title
jtran
approved these changes
Aug 27, 2026
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
August 27, 2026 23:57
e05cb6e to
c081596
Compare
adamchalmers
added a commit
to KittyCAD/modeling-app
that referenced
this pull request
Aug 28, 2026
These will be used to pull CadOperation into the modeling-cmds API, so it can be returned during engine execution. Part of #12500 Used in KittyCAD/modeling-api#1348
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
2 times, most recently
from
August 28, 2026 02:36
ee9192e to
51c7d42
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage ? 34.65%
=======================================
Files ? 32
Lines ? 1717
Branches ? 0
=======================================
Hits ? 595
Misses ? 1122
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
August 28, 2026 14:01
b9236fb to
387c76f
Compare
adamchalmers
added a commit
to KittyCAD/modeling-app
that referenced
this pull request
Sep 4, 2026
Next step of #12500, moving more KCL types out of kcl-lib and "pushing them down" into kcl-api, so they can be brought into kcmc. Once this PR merges, I can update kcmc's "execute KCL project on engine" response types so they return the variables map too. Sometimes it doesn't make sense to move the type entirely down into kcl-api, because the type is inherently structured for runtime execution, not for a simple interface definition, or de/serialization. In that case, I add a new `FooView` type instead of moving `Foo` down. Generally `FooView` can be made `From<&Foo>` and impls De/Serialize. Alas, some of these types from kcl-lib use types from kcmc, so those kcmc types _also_ have to be pushed down into kcl-api. Including the Point2d and Point3d types. Those changes are integrated into kcmc in this PR: KittyCAD/modeling-api#1348
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
3 times, most recently
from
September 15, 2026 03:21
defbbca to
bca39fe
Compare
adamchalmers
changed the title
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
2 times, most recently
from
September 15, 2026 21:38
2763649 to
203809f
Compare
jtran
reviewed
Sep 17, 2026
| /// Fatal KCL errors that prevented your geometry from being created. | ||
| pub error: Option<KclError>, | ||
| /// Nonfatal KCL errors that need to be fixed. | ||
| /// Operations that have been performed in execution order, grouped by |
Contributor
There was a problem hiding this comment.
I think that ideally pub artifact_graph: ArtifactGraph, would be included above here. We made that mistake in a prior change.
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
September 22, 2026 21:58
203809f to
1ef306b
Compare
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
September 23, 2026 02:46
1ef306b to
6576113
Compare
adamchalmers
added a commit
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires KittyCAD/modeling-app#13362, CI will not pass until that is released.
Part of engine execution effort: KittyCAD/modeling-app#12500
Do not merge until the engine PR is ready.