Return artifact graph in exec_kcl_project response#1295
Open
lee-at-zoo-corp wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
=======================================
Coverage ? 31.35%
=======================================
Files ? 36
Lines ? 1802
Branches ? 0
=======================================
Hits ? 565
Misses ? 1237
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lee-at-zoo-corp
force-pushed
the
lee-at-zoo-corp/return-artifact-graph
branch
from
July 24, 2026 14:36
4e468b3 to
9701159
Compare
lee-at-zoo-corp
marked this pull request as ready for review
July 24, 2026 14:41
therapon
approved these changes
Jul 27, 2026
jtran
reviewed
Jul 27, 2026
| // Should be a usable subset of `SceneGraphDelta`. | ||
| /// The artifact graph produced by the KCL execution. | ||
| #[cfg(feature = "websocket")] | ||
| pub artifact_graph: serde_json::Value, |
Contributor
There was a problem hiding this comment.
Shouldn't we use an actual type? serde_json::Value is basically a JSON blob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
artifact_graphfield toExecKclProjectOkso that the artifact graph built during KCL execution is returned to the caller.