Skip to content

Fix Machine API dependency compatibility - #423

Draft
JordanNoone wants to merge 3 commits into
mainfrom
codex/machine-api-ci-compatibility
Draft

JordanNoone wants to merge 3 commits into
mainfrom
codex/machine-api-ci-compatibility

Conversation

@JordanNoone

@JordanNoone JordanNoone commented Sep 15, 2026

Copy link
Copy Markdown

Fix the dependency API mismatches blocking compilation: align Bambu’s Rustls version and OpenTelemetry’s exporter, update Dropshot configuration and both mDNS call sites, and select Bambu’s crypto provider explicitly to prevent startup panics.

Refs #422; incorporates the dependency bumps from #392 and #377.

Verified on 6a89aed: CI build, all 42 tests, formatting and security checks pass; the local Bambu constructor check also passes. Clippy still stops at three existing large-enum warnings tracked in #422. Printer connectivity and telemetry delivery remain unverified.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.05%. Comparing base (1550a39) to head (6a89aed).
⚠️ Report is 101 commits behind head on main.

Files with missing lines Patch % Lines
bambulabs/src/client.rs 0.00% 8 Missing ⚠️
src/bin/machine-api/cmd_serve.rs 0.00% 2 Missing ⚠️
src/bin/machine-api/main.rs 0.00% 2 Missing ⚠️
src/server/mod.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   24.14%   20.05%   -4.10%     
==========================================
  Files          46       44       -2     
  Lines        3164     2698     -466     
==========================================
- Hits          764      541     -223     
+ Misses       2400     2157     -243     
Flag Coverage Δ
unittests 20.05% <6.66%> (-4.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant