2.6.0: Update Traits from PHP SDK - #127
Draft
n7studios wants to merge 15 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures the Kit WordPress Libraries as a WordPress mirror of the PHP SDK. API surface, tests, and version numbers now track the SDK; only genuinely WordPress-specific methods and tests stay unique to this repo.
Based on ConvertKitSDK-PHP #155:
ConvertKit_API_Traits, adjusted for PHP 7.x (nullable shorthand, positional args, etc.).TestsTraitverbatim.APITest.phpnow uses the trait and provides two shims (assertApiError,assertLastResponseStatusCode) that translate SDK-style thrown exceptions intoWP_Errorassertions. WP-only tests remain inAPITest.php/ResourceTest.php/APINoDataTest.php.2.6.0to match the SDK release.Future SDK updates port over in two steps: copy the changed API methods into
ConvertKit_API_Traits(with PHP 7.x tweaks), then copy the SDK'sTestsTrait.phpinto this repo.Testing
Existing tests pass. This is a large PR which is difficult to review, so tests are also performed on each Kit WordPress Plugin against this branch to confirm no breaking changes:
Checklist