(janitor/dead-code): remove unused UserAdminExternalLinks component - #5636
Merged
Conversation
This component was superseded by UserAdminAccountInfo, which reimplements the same Stripe/HIBP/Gravatar links inline, and is the one actually rendered by UserAdminTabbedSections. UserAdminExternalLinks has had no importers since the tabbed user-detail layout was introduced in #2196.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-4.6 · Input: 32.1K · Output: 4.1K · Cached: 143.2K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was deleted
apps/web/src/app/admin/components/UserAdmin/UserAdminExternalLinks.tsx— apresentational component that rendered Stripe/Have-I-Been-Pwned/Gravatar
links for an admin user-detail view (51 lines, no other files changed).
Evidence it was unreachable
grep -rn "UserAdminExternalLinks" --include="*.ts" --include="*.tsx" .returns just the
export function UserAdminExternalLinksline in the fileitself.
UserAdminTabbedSections.tsx, imports 12 siblingUserAdmin*componentsbut never
UserAdminExternalLinks.avatar) is fully reimplemented inline in
UserAdminAccountInfo.tsx(
getGravatarUrl,stripeUrl,hibpUrl), which is imported byUserAdminTabbedSections.tsxand rendered in the actual admin UI. This isthe superseding component.
git logshows the file was last touched only by the monorepo restructurecommit and the commit that introduced the tabbed user-detail layout
(feat(admin): add KiloClaw subscription management and tabbed user detail layout #2196) — the layout that composes sibling components but never included
this one, consistent with it being dropped in favor of
UserAdminAccountInfowithout deleting the old file.UserDetailPropstype it consumed isstill used by 13 other
UserAdmin*components.Dynamic and configured entry points checked
page.tsx/route.ts/layout.tsxrole);it's a plain exported component under
app/admin/components/.wrangler.jsonc/tomlreferences, no Durable Object or Cloudflarebinding involvement (this is a
apps/webNext.js component, not aWorker).
package.jsonexportsfield involvement —apps/webis a privateNext.js app, not a published package.
Kilo-Org/kilocode(cloned locally)for any string reference to
UserAdminExternalLinks— zero matches. Thiscomponent has no relationship to the extension/CLI's public API surface
in any case (it's an internal
/adminpage component).Contract and compatibility considerations
is a private, unrendered internal admin UI component. Deleting it does not
change any request/response contract, persisted data shape, or migration.
local pure helper function
getGravatarUrl); nothing is registered in aglobal registry by importing this file.
Validation performed
grep/rgrepo-wide searches (cloud repo) confirming zero importers.grepagainst a fresh clone ofKilo-Org/kilocodeconfirming zeroreferences.
git log --oneline -- <path>history review.oxlintrun againstapps/web/src/app/admin/components/UserAdmin: 0 warnings, 0 errors.apps/webtsc --noEmitwas attempted but runs out of memory inthis sandboxed environment even without this change (pre-existing
environment limitation, not related to this diff); not able to complete
it here. The deletion removes no re-exported type and no other file
imports from the removed file, so no type-check regression is expected.
git diff --checkclean; diff is a single-file, 51-line deletion with noother files touched.