Skip to content

(janitor/dead-code): remove unused UserAdminExternalLinks component - #5636

Merged
pandemicsyn merged 1 commit into
mainfrom
janitor/remove-user-admin-external-links
Aug 28, 2026
Merged

(janitor/dead-code): remove unused UserAdminExternalLinks component#5636
pandemicsyn merged 1 commit into
mainfrom
janitor/remove-user-admin-external-links

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What was deleted

apps/web/src/app/admin/components/UserAdmin/UserAdminExternalLinks.tsx — a
presentational component that rendered Stripe/Have-I-Been-Pwned/Gravatar
links for an admin user-detail view (51 lines, no other files changed).

Evidence it was unreachable

  • Repo-wide symbol search finds only the definition, no importer:
    grep -rn "UserAdminExternalLinks" --include="*.ts" --include="*.tsx" .
    returns just the export function UserAdminExternalLinks line in the file
    itself.
  • The composing view for this feature,
    UserAdminTabbedSections.tsx, imports 12 sibling UserAdmin* components
    but never UserAdminExternalLinks.
  • Its functionality (Stripe customer link, HIBP breach-check link, Gravatar
    avatar) is fully reimplemented inline in UserAdminAccountInfo.tsx
    (getGravatarUrl, stripeUrl, hibpUrl), which is imported by
    UserAdminTabbedSections.tsx and rendered in the actual admin UI. This is
    the superseding component.
  • git log shows the file was last touched only by the monorepo restructure
    commit and the commit that introduced the tabbed user-detail layout
    (feat(admin): add KiloClaw subscription management and tabbed user detail layout #2196) — the layout that composes sibling components but never included
    this one, consistent with it being dropped in favor of
    UserAdminAccountInfo without deleting the old file.
  • No newly-orphaned code: the shared UserDetailProps type it consumed is
    still used by 13 other UserAdmin* components.

Dynamic and configured entry points checked

  • Not a Next.js convention file (no page.tsx/route.ts/layout.tsx role);
    it's a plain exported component under app/admin/components/.
  • No wrangler.jsonc/toml references, no Durable Object or Cloudflare
    binding involvement (this is a apps/web Next.js component, not a
    Worker).
  • No package.json exports field involvement — apps/web is a private
    Next.js app, not a published package.
  • Checked the external consumer repo Kilo-Org/kilocode (cloned locally)
    for any string reference to UserAdminExternalLinks — zero matches. This
    component has no relationship to the extension/CLI's public API surface
    in any case (it's an internal /admin page component).

Contract and compatibility considerations

  • No public/published SDK export, no tRPC procedure, no route change — this
    is a private, unrendered internal admin UI component. Deleting it does not
    change any request/response contract, persisted data shape, or migration.
  • No side effects on module load (pure presentational component with a
    local pure helper function getGravatarUrl); nothing is registered in a
    global registry by importing this file.

Validation performed

  • grep/rg repo-wide searches (cloud repo) confirming zero importers.
  • grep against a fresh clone of Kilo-Org/kilocode confirming zero
    references.
  • git log --oneline -- <path> history review.
  • Scoped oxlint run against
    apps/web/src/app/admin/components/UserAdmin: 0 warnings, 0 errors.
  • Full apps/web tsc --noEmit was attempted but runs out of memory in
    this sandboxed environment even without this change (pre-existing
    environment limitation, not related to this diff); not able to complete
    it here. The deletion removes no re-exported type and no other file
    imports from the removed file, so no type-check regression is expected.
  • git diff --check clean; diff is a single-file, 51-line deletion with no
    other files touched.

This component was superseded by UserAdminAccountInfo, which
reimplements the same Stripe/HIBP/Gravatar links inline, and is the
one actually rendered by UserAdminTabbedSections. UserAdminExternalLinks
has had no importers since the tabbed user-detail layout was introduced
in #2196.
@kilo-code-bot kilo-code-bot Bot added the janitor Automated dead-code/duplication cleanup label Aug 28, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • apps/web/src/app/admin/components/UserAdmin/UserAdminExternalLinks.tsx

Reviewed by grok-4.6 · Input: 32.1K · Output: 4.1K · Cached: 143.2K

Review guidance: REVIEW.md from base branch main

@pandemicsyn
pandemicsyn merged commit 45491c3 into main Aug 28, 2026
17 checks passed
@pandemicsyn
pandemicsyn deleted the janitor/remove-user-admin-external-links branch August 28, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

janitor Automated dead-code/duplication cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant